This is mostly working. Building storybook succeeds, and sb-preview/runtime.mjs is no longer being bundled. Storybook loads the page correctly, but changing stories by clicking in the sidebar is broken, in both dev and built storybooks. Refreshing the page will load the correct story. The webpack projects are working correctly, just not vite, and I'm not sure why. Maybe @ndelangen you might have an idea here?

@IanVS I'm still seeing this in the dev mode of storybook:

Also see it in build-mode

I build-mode i can see it working though:

Also confirmed to be working in dev-mode:

The CI error is weird because it's a peerDep and we add it to the project when initializing storybook:

How could the dep not be there?

can confirm, it's not being added as a dep when running the sanbox command:

  "dependencies": {
    "@types/node": "16",
    "lit": "^2.4.0"
  },

Need to debug this, why

@IanVS I think I found the problem:

conflicts with:

// sandbox/lit-vite-default-ts/vite.config.ts

import { defineConfig } from 'vite';

export default defineConfig({
  build: {
    lib: {
      entry: 'src/my-element.ts',
      formats: ['es']
    },
    rollupOptions: {
      external: /^lit/
    }
  }
})

Might not be getting merged correctly?

Also there's this code:

Or maybe this:

external: /^lit/

Matches too much?

I tried removing that bit of code from the sandbox's vite.config.ts, and that made no difference..

Another bit of information @IanVS the dev-mode is working fine, it's only a problem when building storybook.

the main.js viteFinal method is the same across all 4 vite sandboxes are exactly the same.